-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark widgets as non timezone sensitive #14497
Conversation
fcc0295
to
0fa51b2
Compare
kicked - master is green now |
Checked commit kbrock@0fa51b2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
ping @martinpovolny this work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
Just afraid, that copy-paste programmers will not copy-paste this one to other reports :-D
@isimluk would you prefer that we look at the columns brought back and detect a date column? That part of detection is easy, it is detection in the |
I am ok with this as it is. This is an improvement and I want to get it in. End of story. :-) We have a huge pile of Work-in-progress. We should hire someone with MBA to tell us that is not good. :) This is an improvement and I want to get it in. |
Ping @martinpovolny, did you want to take a look also? |
@martinpovolny this good for you? |
These pr review are really a step back from where the things used to be. http://web.mit.edu/humor/Computers/real.programmers |
Sorry for taking so long. I failed to review my core review queue for some time :-( |
@kbrock : fine yes/no? |
Thanks martin. Yes, we have other PRs in Fine, so marking as |
Mark widgets as non timezone sensitive (cherry picked from commit 03f378c) https://bugzilla.redhat.com/show_bug.cgi?id=1251259
Fine backport details:
|
This is a followup to #14386 which has been backported to |
Follow up to #14386 (to concept introduced in #14285 )
This change allows these widgets to run once per security group rather than once per timezone per security group. (expecting 1/2 the number of reports to run per widget)
Assumes: widgets that do not reference time-sensitive columns are not timezone-sensitive.
In the end, 12 reports do not need the timezone. 3 had already been updated, so this updates the remaining 9 report files used by widgets.
operating_system.product_name, operating_system.service_pack, name, vendor_display, os_image_name, operating_system.version, operating_system.build_number, operating_system.product_key, operating_system.productid
name, ipaddress, vmm_vendor_display, vmm_product, vmm_version, vmm_buildnumber
name, computer_system.hardware.cpu_total_cores
name, ready_condition_status
vendor_display, operating_system.product_name, name, operating_system.name
vmm_vendor_display, vmm_product, operating_system.product_name, name
name, computer_system.hardware.cpu_total_cores, computer_system.hardware.memory_mb
name,
max_cpu_usage_rate_average_avg_over_time_period
name,
max_mem_usage_absolute_average_avg_over_time_period
name,ready_condition_status
name,
max_cpu_usage_rate_average_avg_over_time_period
name,
max_mem_usage_absolute_average_avg_over_time_period
name, containers_count
name, groups_count
name, ready_condition_status,
ems_created_on
resource_name, ems_cluster.name, host.name,
cpu_usage_rate_average__avg
,cpu_usage_rate_average
resource_name, ems_cluster.name, host.name,
derived_memory_used__avg
,derived_memory_used
name, ems_cluster.name, host.name, used_disk_storage, provisioned_storage
name, tenant_quotas.name, tenant_quotas.total, tenant_quotas.used, tenant_quotas.allocated, tenant_quotas.available